[gstreamer-bugs] [Bug 628014] Deprecate GST_FLOW_IS_FATAL/GST_FLOW_IS_SUCCESS

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Aug 27 10:03:05 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=628014
  GStreamer | gstreamer (core) | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.31

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-27 17:03:03 UTC ---
Done... and patches for all non-frozen modules pushed (good/bad/ugly will be
pushed immediately after release).


commit d7f59ca0c4d14b658331c7a80bc99efcdee05d19
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Thu Aug 26 23:07:51 2010 +0200

    pad: Deprecate GST_FLOW_IS_FATAL() and GST_FLOW_IS_SUCCESS()

    The problem with both macros is, that they suggest something that isn't
true.
    If GST_FLOW_IS_FATAL is true, there could still be a problem for many
elements
    and they should stop what they're currently doing and return that value
    upstream (e.g. not-linked in a parser). If GST_FLOW_IS_SUCCESS is false, it
    could still be that this is "ok" for the element (e.g. not-linked for a
demuxer
    on a few of its pads but not all).

    It's better to not have these "convenience" macros but instead let people
    *think* about the handling of different flow returns, that makes sense for
    their element. And we should document the expected handling of flow returns
for
    different classes of elements in the plugin writer's guide.

    Fixes bug #628014.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list