[gstreamer-bugs] [Bug 623121] [queue2] downloaded areas of the media are not exposed

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Aug 31 05:41:58 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=623121
  GStreamer | gstreamer (core) | git

--- Comment #11 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-31 12:41:53 UTC ---
(In reply to comment #10)

> > @@ +1329,3 @@
> > +  value = gst_structure_id_get_value (structure, GST_QUARK
> > (BUFFERING_RANGES));
> > +  ranges = g_value_array_copy ((GValueArray *) g_value_get_boxed (value));
> > +  return ranges;
> > 
> > For other queries, events, etc the API usually is, that the parsed data is
> > owned by the query and only valid as long as the query is there.
> 
> Well the other queries handle simpler types, at least from what I read in
> gstquery.c... I don't really see how to avoid the copy here.

Just "return (GValueArray *) g_value_get_boxed (value)"


I was thinking of the _get_structure() methods of event, query and message or
the taglist getters.
OTOH gst_query_get_uri() returns a copy. We need a second opinion here :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list