[gstreamer-bugs] [Bug 627476] New profile library and encoding plugin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627476
  GStreamer | gst-plugins-base | git

--- Comment #20 from Edward Hervey <bilboed at gmail.com> 2010-12-07 15:35:04 UTC ---
(In reply to comment #19)
> Just for reference the branch with the latest changes (as the patches don't
> apply anymore):
> http://cgit.freedesktop.org/~bilboed/gst-plugins-base/tree/?h=profile
> 
> Thanks for adding the examples:
> * In the "Loading a profile from disk" example it is not obvious where the
> "profilename" comes from. Should apps scan a particular dir for available
> profiles? Also see my comment on
> gst_encoding_target_load/gst_encoding_target_save below. 

  That was just an example for getting a specific profile from a target.

  You can also just load a target and iterate the available profiles.

> 
> A small ambiguity is that in the example you call the
> gst_encoding_target_load_from() with a parameter called uir, where in the API
> docs you refer to it as a path. Would be good to fix either one.

  fixed

> 
> Regarding the API:
> 
> * gst_video_encoding_profile_new()
> the 'vfr' parameter is not docuemnted and I wonder if you could perhaps spell
> it out. The parameter is documented in GstVideoEncodingProfile.

  I renamed it to variableframerate. Long... but explanatory.

> 
> * if there is a gst_stream_encoding_profile_new() and
> gst_video_encoding_profile_new(), shouldn't there be a
> gst_audio_encoding_profile_new() too? Or is it so that right now
> GstAudioEncodingProfile==GstVideoEncodingProfile (aka no specific parameters
> for audio)?

  I did a separate constructor for video since there are extra fields (passes).

> 
> So basically the only open Item for me is, how an application would look up
> available targets.
> 
> * gst_encoding_target_load/gst_encoding_target_save is not implemented. I
> believe specifying the locations (like done for GstPreset) would make sense.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.