[gstreamer-bugs] [Bug 627476] New profile library and encoding plugin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627476
  GStreamer | gst-plugins-base | git

--- Comment #25 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-12-12 15:14:32 UTC ---
Also had a quick look at encodebin and the other elements:

 - a gtk-doc chunk/section with some feature/usage details would be nice

 - gstencodebin.h: leftover constructor declaration: gst_encode_bin_new ()

 - gstencodebin.h: could be made static gst_encode_bin_set_profile ()

 - src pad: is there a reason the src pad is a sometimes pad and
    created in response to g_object_set()ing the profile; would it be
    possible to make it an always pad (which may or may not have a
    target to start with), so people can just link it right away without
    worrying about the sometimes-pad aspect?

 - "use-smartencoder" property - a name derived from the
    feature/function and not the implementation detail might
    be nicer, if anyone can think of one

 -  the "request-pad" action signal is a bit confusing - how does
     it work together with the normal request pad procedure? Does
     it need to be released again? Maybe we should instead add
     some kind of new gst_element_request_pad_for_caps() API to
     core/GstElementClass instead?

 - not sure about the labelling of unknown/other streams as
    'private' - when it's really just unknown/other

 - docs/design/design-encoding.txt code example refers to
    "profile" property of string type:
    g_object_set (encbin, "profile", "N900/H264 HQ", NULL),
    whereas it seems to be a mini object now

 - "smartencoder" - can anyone think of a better name for this?
    ("smart" doesn't really tell anyone anything unless they
    already know what it does exactly) :)

 - smartencoder: should post an error with GST_ELEMENT_ERROR
    when returning GST_FLOW_ERROR

 - streamsplitter: should post an error with GST_ELEMENT_ERROR
    when returning GST_FLOW_ERROR

 - a small section in the design docs how streamsplitter/combiner +
   smartencoder work together would be nice

 - are streamsplitter/combiner/smartencoder useful outside of encodebin
   or should they maybe be kept private for now?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.