[gstreamer-bugs] [Bug 637300] [API] request pad based on caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=637300
  GStreamer | gstreamer (core) | git

--- Comment #4 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-12-20 20:33:15 UTC ---
Review of attachment 176760:
 --> (https://bugzilla.gnome.org/review?bug=637300&attachment=176760)

::: gst/gstelement.c
@@ +1106,3 @@
+
+  /* If the element class implements the request_new_pad_full() vmethod,
+   * use that. */

the comment would suggest that we can do some fallback, if the class does not
implement request_new_pad_full(). Can we?

@@ -1077,0 +1079,40 @@
+ * gst_element_get_request_pad_by_caps:
+ * @element: a #GstElement to find a request pad of.
+ * @direction: the direction of the pad to request
... 37 more ...

leftover goto?

::: gst/gstelement.h
@@ +669,3 @@
+  /* Virtual method for subclasses (additions) */
+  GstPad*        (*request_new_pad_full) (GstElement *element, GstPadTemplate
*templ, const gchar* name);
+

Should there be a FIXME-0.11: comment to drop it and move the new behavior to
the old method?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.