[gstreamer-bugs] [Bug 637586] playbin2 fails to recognize subtitle caps from katedec

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=637586
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176815|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2010-12-21 16:25:41 UTC ---
Review of attachment 176815:
 --> (https://bugzilla.gnome.org/review?bug=637586&attachment=176815)

Looks good in general, just some cosmetic/minor things, after that I'll push
this change :)

::: gst/playback/gstplaybin2.c
@@ +2323,3 @@

+static gboolean
+event_data_probe (GstPad * pad, GstMiniObject * object, gpointer data)

Maybe call it stream_changed_data_probe. It's not really an event data probe

@@ +2344,3 @@
+    /* push the event first, then send the delayed one */
+    gst_event_ref (GST_EVENT (object));
+    gst_pad_send_event (pad, GST_EVENT (object));

Please cast with GST_EVENT_CAST() here. You already know that it is an event :)

@@ +2797,3 @@
+
+        /* remove any data probe we might have, and replace */
+        select->sinkpad_delayed_event = event;

You'll be leaking any previously set event here. To be on the safe side unref
any events here first

Maybe also add a comment here why we're not sending the event directly but
defer it to the data probe (1: send it from the correct streaming thread, 2:
pushing the event could block, leading to a deadlock, 3: things might not be
linked correctly yet, after the data probe is called it will)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.