[gstreamer-bugs] [Bug 637927] oggdemux: set headers on caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=637927
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176995|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2010-12-24 13:10:02 UTC ---
Review of attachment 176995:
 --> (https://bugzilla.gnome.org/review?bug=637927&attachment=176995)

Good patch, just two really minor things :)

::: ext/ogg/gstoggdemux.c
@@ +1741,3 @@
+    GST_BUFFER_FLAG_SET (buffer, GST_BUFFER_FLAG_IN_CAPS);
+    g_value_init (&value, GST_TYPE_BUFFER);
+    gst_value_set_buffer (&value, buffer);

You could use gst_value_take_buffer() here to prevent copying the data twice

@@ +1842,3 @@

+    /* Set headers on caps */
+    caps = gst_caps_copy (pad->map.caps);

Just use gst_caps_make_writable() here and change the mapper caps inplace

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.