[gstreamer-bugs] [Bug 638107] New: [mp4mux] cover art lost when transcoding from flac to mp4
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Dec 27 05:08:56 PST 2010
https://bugzilla.gnome.org/show_bug.cgi?id=638107
GStreamer | gst-plugins-bad | git
Summary: [mp4mux] cover art lost when transcoding from flac to
mp4
Classification: Desktop
Product: GStreamer
Version: git
OS/Version: Linux
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: gst-plugins-bad
AssignedTo: gstreamer-bugs at lists.sourceforge.net
ReportedBy: antonio.frediani at inwind.it
QAContact: gstreamer-bugs at lists.sourceforge.net
GNOME target: ---
GNOME version: ---
Created an attachment (id=177093)
View: https://bugzilla.gnome.org/attachment.cgi?id=177093
Review: https://bugzilla.gnome.org/review?bug=638107&attachment=177093
Simply add the GST_TAG_IMAGE handling, working exactly like
GST_TAG_PREVIEW_IMAGE
When transcoding from flac to mp4/aac the cover art was not preserved.
The problem seems to be that flac embedded pictures are decoded as "image"
(GST_TAG_IMAGE) by flacdec, while mp4mux only handled GST_TAG_PREVIEW_IMAGE.
Adding the handling of GST_TAG_IMAGE within the tag_matches_mp4 struct seemed
to work for me.
I attach the patch against the current git trunk. I used the same fourcc as the
existing GST_TAG_PREVIEW_IMAGE, from a quick research it doesn't seem to me
this could be a problem, but please feel free to point me to the appropriate
documentation if this isn't the case.
The command line I used for testing was:
gst-launch-0.10 filesrc location = filename.flac ! flacdec ! faac profile=2
bitrate=224000 ! mp4mux ! filesink location=filename.m4a
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the Gstreamer-bugs
mailing list