[gstreamer-bugs] [Bug 609252] New: theoradec doesn't handle unknown pixel aspect ratio properly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=609252
  GStreamer | gst-plugins-base | git

           Summary: theoradec doesn't handle unknown pixel aspect ratio
                    properly
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: bens at alum.mit.edu
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=153209)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=153209)
patch to fix handling of 0:x PAR

gsttheoradec.c currently says of the pixel aspect ratio

"""
   * 0:0 is allowed and can be interpreted as 1:1, so correct for it.
   * x:0 for other x isn't technically allowed, but it's seen in the wild and
   * is reasonable to treat the same
"""

0:x is treated as 0/x = 0.  This is not correct.  The Theora spec says

"""
If either of these fields are zero, this indicates
that pixel aspect ratio information was not available to the encoder. In
this case it MAY be specified by the application via an external means,
or a default value of 1 : 1 MAY be used.
"""

With the current behavior, I believe a file with PAR 0:x fails to play, and
produces errors like

** (totem:14347): CRITICAL **: gst_video_calculate_display_ratio: assertion
`num > 0' failed

Attached is a patch to follow the spec.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.