[gstreamer-bugs] [Bug 609460] New: asfdemux can crash when NULL tag names are present

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=609460
  GStreamer | gst-plugins-ugly | 0.10.25

           Summary: asfdemux can crash when NULL tag names are present
    Classification: Desktop
           Product: GStreamer
           Version: 0.10.25
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: sean at chumby.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=153364)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=153364)
Patch to check for NULL tag names and ignore them.

BACKGROUND:

It seems as though it's possible to create ASF streams that have NULL tags. 
When asfdemux goes to read these tags, the plugin will crash with a segfault.


STEPS TO REPRODUCE:

Locate a WMV file with an extended content section with NULL tags and attempt
to play it.


EXPECTED RESULTS:

The file should play.


OBSERVED RESULTS:

The file crashes with a segfault.  Relevant logs:

0:00:39.239915077  2115    0x14008 LOG               GST_STATES
gstelement.c:2772:gst_element_change_state_func:<disk_source> default handler
tries setting state from READY to PAUSED (0013)
0:00:39.240396307  2115   0x1213d0 LOG                 asfdemux
gstasfdemux.c:712:gst_asf_demux_identify_guid: ASF_OBJ_EXT_CONTENT_DESC 
0xd2d0a440-0x11d2e307-0xa000f097-0x50a85ec9
0:00:39.240864923  2115   0x1213d0 INFO                asfdemux
gstasfdemux.c:3335:gst_asf_demux_process_object: HEADER/EXT_CONTENT_DESC: size
278
0:00:39.241295692  2115   0x1213d0 INFO                asfdemux
gstasfdemux.c:2318:gst_asf_demux_process_ext_content_desc:<asfdemux0> object is
an extended content description
0:00:39.241735077  2115   0x1213d0 DEBUG               asfdemux
gstasfdemux.c:2359:gst_asf_demux_process_ext_content_desc: Found tag/metadata
(null)
Segmentation fault


Attached is a patch which fixes it on our system.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.