[gstreamer-bugs] [Bug 609639] New: xviddec plugin caps does not allow MPEG 4 video - trivial fix

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=609639
  GStreamer | gst-plugins-bad | unspecified

           Summary: xviddec plugin caps does not allow MPEG 4 video -
                    trivial fix
    Classification: Desktop
           Product: GStreamer
           Version: unspecified
        OS/Version: All
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: somebodys.home.is at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


The XVid Plugins use their own caps "video/x-xvid", however as XVid is an
implementation of MPEG4 it would be useful for the caps to allow for MPEG4 as
well. The Encoder does currently allow the src caps to be MPEG4, however the
Decoder sink caps only allows xvid. As MPEG4 decoders are defined by the
specification I believe that simply changing the caps to allow MPEG4 should
work. This would be useful as the XVID decoders are very efficient and could be
used instead of ffdec_mpeg4.

The fix is absolutely trivial, I've tested it by adding the following caps to
the decoder's sink template in "/gstpluginsbad/ext/xvid/xviddec.c":

  "video/mpeg, "
  "mpegversion = (int) 4, "
  "systemstream = (boolean) FALSE, "
  "width = (int) [ 0, MAX ], "
  "height = (int) [ 0, MAX ], " "framerate = (fraction) [ 0/1, MAX ]

This then works with the following pipelines:
  gst-launch videotestsrc ! ffenc_mpeg4 ! xviddec ! ffmpegcolorspace !
xvimagesink

  gst-launch videotestsrc ! xvidenc ! 'video/mpeg, mpegversion=(int)4' !
xviddec ! ffmpegcolorspace ! xvimagesink

Nick

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.