[gstreamer-bugs] [Bug 610238] New: Avoid an assertion in the rtspsrc element which abort the client application

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=610238
  GStreamer | gst-plugins-good | 0.10.16

           Summary: Avoid an assertion in the rtspsrc element which abort
                    the client application
    Classification: Desktop
           Product: GStreamer
           Version: 0.10.16
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: anders.skargren at axis.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=154010)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=154010)
Small patch to check src->task before trying to issue a gst_task_pause()

Scenario:
Set the rtspsrc to only allow multicast.
Try to receive a multicast stream from a server.
Make sure the rtspsrc never receives any multicast rtp packets and let it time
out.

Problem:
When you use the rtspsrc element to try to retrieve a multicast stream while
having disabled the TCP fallback, it can throw an abort on the  gst_task_pause
(src->task); in gst_rtspsrc_loop().

Reason being that the gst_rtspsrc_loop_udp() function has already removed the
src->task and set the pointer to NULL. It then realizes that TCP is disabled
and errors out using the no_protocols target.

The error handling in gst_rtspsrc_loop() then tries to issue a gst_task_pause()
on a NULL pointer.

Included a very small patch that checks src->task before trying to issue the
gst_task_pause(src->task);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.