[gstreamer-bugs] [Bug 610246] [optimization] Speed up _get_range()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=610246
  GStreamer | gstreamer (core) | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.27

--- Comment #3 from Edward Hervey <bilboed at gmail.com> 2010-02-17 11:37:59 UTC ---
commit 1f0b6f35d5cd5a9fe7272c82e680eb2b84655015
Author: Edward Hervey <bilboed at bilboed.com>
Date:   Wed Feb 17 12:16:37 2010 +0100

    filesrc: Don't use expensive cast checks in _create

    _create() is a pad function set by ourselves, therefore we're sure basesrc
    is a GstFileSrc.

    Speeds up _create() by 17% and the total call by 8% (instruction calls
measurements
    done with valgrind).

    Fixes #610246

commit bc9e129990805b065e7a0357590cf1e580d9ffad
Author: Edward Hervey <bilboed at bilboed.com>
Date:   Wed Feb 17 12:14:09 2010 +0100

    basesrc: Don't use expensive cast checks in get_range.

    _get_range() is a pad function set by ourselves, therefore we're certain
that
    the parent is a GstBaseSrc.

    Speeds up _get_range by 38%, and the total call by 30%. (valgrind
instruction
    calls measurements).

    Fixes #610246

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.