[gstreamer-bugs] [Bug 606689] New: Re-send codec data on GstForceKeyUnit

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=606689
  GStreamer | gst-plugins-good | git

           Summary: Re-send codec data on GstForceKeyUnit
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: tester at tester.ca
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=151206)
 View: https://bugzilla.gnome.org/attachment.cgi?id=151206
 Review: https://bugzilla.gnome.org/review?bug=606689&attachment=151206

Design docs update for resending codec key data

It seems that in some cases, we want to resend the codec data (like the SPS/PPS
in H.264 or the Theora header) on GstForceKeyUnit, but in somes cases we don't
(RTCP XR FIR vs RTCP XR PLI).

So I think it should be stated in the event, either positively or negatively.
I'm entirely undecided on which to choose, my demo implementation has a
"send-codecdata" boolean, but I don't like the name much. Ideally, the
previously intended behavior should be kept, but I'm not sure what that
behavior was.

Also, for this to work, the downstream event needs to preserve the properties
of the upstream one. I added some code that copies the event, changes the type
and sends it back downstream to theoraenc and rtph264enc. Maybe there is a
better way to do it.

Third interrogation is who should be resending these things. I implemented it
in rtph264pay, but maybe it should be the encoder. Otherwise, muxers that react
to this event will also have to keep it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.