[gstreamer-bugs] [Bug 607555] asfmux plugin generates data streams incompatible with WMSP (MMSH) and WMP

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=607555
  GStreamer | gst-plugins-bad | 0.10.25

Thiago Sousa Santos <thiago.sousa.santos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151838|none                        |reviewed
             status|                            |

--- Comment #6 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2010-01-21 17:14:37 UTC ---
Review of attachment 151838:
 --> (https://bugzilla.gnome.org/review?bug=607555&attachment=151838)

1549      /* Due to a limitation in WMP while streaming through WMSP we reduce
the
1520      GST_WRITE_UINT32_LE (data + 6, size_left);    /* padding size */     
  1550       * packet & padding size to 16bit if theay are <= 65535 bytes 
1551       */
1552      if (asfmux->packet_size > 65535) {
1553        GST_WRITE_UINT32_LE (data + offset, asfmux->packet_size -
size_left);
1554        offset += 4;
1555      } else {
1556        *data &= ~(ASF_FIELD_TYPE_MASK << 5);
1557        *data |= ASF_FIELD_TYPE_WORD << 5;
1558        GST_WRITE_UINT16_LE (data + offset, asfmux->packet_size -
size_left);
1559        offset += 2;
1560      }

Why are you using "packet_size - size_left" here?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.