[gstreamer-bugs] [Bug 607698] New: asfdemux: fix parsing of packets with padding

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=607698
  GStreamer | gst-plugins-ugly | git

           Summary: asfdemux: fix parsing of packets with padding
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: thiago.sousa.santos at collabora.co.uk
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: thiago.sousa.santos at collabora.co.uk, skjelten at pvv.org
        Depends on: 607555
      GNOME target: ---
     GNOME version: ---


+++ This bug was initially created as a clone of Bug #607555 +++

On this comment in 607555 a possible bug was found in asfdemux, so here is a
clone to track the separate issue.

> Review of attachment 151838 [details] [details]:
> 
> 1549      /* Due to a limitation in WMP while streaming through WMSP we reduce
> the
> 1520      GST_WRITE_UINT32_LE (data + 6, size_left);    /* padding size */     
>   1550       * packet & padding size to 16bit if theay are <= 65535 bytes 
> 1551       */
> 1552      if (asfmux->packet_size > 65535) {
> 1553        GST_WRITE_UINT32_LE (data + offset, asfmux->packet_size -
> size_left);
> 1554        offset += 4;
> 1555      } else {
> 1556        *data &= ~(ASF_FIELD_TYPE_MASK << 5);
> 1557        *data |= ASF_FIELD_TYPE_WORD << 5;
> 1558        GST_WRITE_UINT16_LE (data + offset, asfmux->packet_size -
> size_left);
> 1559        offset += 2;
> 1560      }
> 
> Why are you using "packet_size - size_left" here?

Because we want to write the size of codec data - and _not_ the size of (codec
data + padding). That's why we must remove size_left (= padding).

The funny thing is that this bug also is found in the gstreamer's asfdemuxer.
I'll attach a quick patch to fix the asfdemuxer as well. I don't know if we
should open a new bug on gstreamer-ugly, but I guess you can just commit a fix
when you find a solution you like.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.