[gstreamer-bugs] [Bug 607771] [API] Add gst_byte_writer_put_padding

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=607771
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-01-22 15:05:22 UTC ---
Thoughts and minor nitpicks:

 - the 'update .defs' commit should be merged with
   the initial commit that adds the API IMHO

 - commit message: the 'API' marker should be in the
   message body not the first line (that's how we mostly
   do it, with one or two exceptions), e.g.:

      bytewriter: add _put_padding function

      Adds a new function to GstByteWriter....

      API: gst_byte_writer_put_padding()

 - I think it should either be called _put_padding() with
   the value argument removed (does anyone ever want
   to add non-0 padding bytes?), or one should rename
   it to something else (don't ask me what though,
   something with 'fill' maybe or 'memset' or 'set'?)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.