[gstreamer-bugs] [Bug 623272] New: [dshowvideosink] setting force-aspect-ratio has no effect after the sink's renderer has been configured

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=623272
  GStreamer | gst-plugins-bad | git

           Summary: [dshowvideosink] setting force-aspect-ratio has no
                    effect after the sink's renderer has been configured
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: phil at base-art.net
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


When the force-aspect-ratio property has been updated the sink's renderer
should be partially reconfigured, this code should be called, I think:

    if (sink->keep_aspect_ratio) {
      control->SetAspectRatioMode(VMR9ARMode_LetterBox);
    }
    else {
      control->SetAspectRatioMode(VMR9ARMode_None);
    }

So maybe we could add a new virtual function RendererSupport to call this code
and call the new function when the property has been set.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.