[gstreamer-bugs] [Bug 612244] v4l2sink updates

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=612244
  GStreamer | gst-plugins-good | git

--- Comment #34 from Rob Clark <rob at ti.com> 2010-07-03 23:13:47 UTC ---
(In reply to comment #33)
> What exactly is the code that needs to be shared? Which files? How many lines?
> 
> I don't think having some code copy'n'pasted is a big problem tbh, and it's not
> code that's touched very often anyway. The only reason the code in the v4l2
> plugin still exists in the current form is because it was made non-experimental
> too early by someone without too much knowledge about why it was still
> experimental, which limited the refactoring that could be done (but was planned
> originally). Almost everyone I know who's hacked on v4l2src thinks that all the
> abstraction and indirection going on here is a disaster and doesn't help
> maintainability or hackability.
> 
> No supporting library please.

fwiw:

   631   1991  18109 gstv4l2bufferpool.c
    97    400   3648 gstv4l2bufferpool.h
    75    287   2526 gstv4l2.c
   106    337   3061 gstv4l2colorbalance.c
   104    387   5892 gstv4l2colorbalance.h
  2120   6567  63282 gstv4l2object.c
   239    890  10613 gstv4l2object.h
  1005   3109  32368 gstv4l2sink.c
    90    313   2591 gstv4l2sink.h
  1015   3018  28656 gstv4l2src.c
    99    307   2565 gstv4l2src.h
   364    982   9991 gstv4l2tuner.c
   198    723  12047 gstv4l2tuner.h
   104    325   2916 gstv4l2vidorient.c
   117    508   8916 gstv4l2vidorient.h
   359   1036   9622 gstv4l2xoverlay.c
    66    263   2998 gstv4l2xoverlay.h
   858   2562  25613 v4l2_calls.c
   145    561   5145 v4l2_calls.h
   443   1362  12746 v4l2src_calls.c
    45    215   1733 v4l2src_calls.h
  8280  26143 265038 total

of this bufferpool, colorbalance, v4l2object, tuner, vidorient, xoverlay
(possibly) and v4l2_calls is shared at least to some extent by v4l2src and
v4l2sink... bufferpool, v4l2object, and v4l2_calls would probably be shared by
memory to memory elements.  There is more code that is shared than not.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.