[gstreamer-bugs] [Bug 623589] Fix races/refcounting bugs with slave clocks

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=623589
  GStreamer | gstreamer (core) | git

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim.taymans at gmail.com

--- Comment #5 from Wim Taymans <wim.taymans at gmail.com> 2010-07-05 11:53:59 UTC ---
> +  GDestroyNotify     destroy_data;
> 
> We can't do that, GstClockEntry is public and this changes its size.

This is going to fail when someone were to allocate a GstClockID themselves
with the slice allocator and so, instead of using the _new_*_id() functions.

If someone would do that, it would have failed previously as well because you
need to give the size to the slice allocator to free the entry (and that size
would be wrong when someone extended the structure and used the default unref
function).

The only way it could have worked previously is when the custom GstClockEntry
allocator would keep an extra ref to the entry and free them when cleaning up. 

None of the existing elements that perform sync would ever manage to allocate
such an entry..

I'm pretty confident nobody does this and that making the struct bigger is not
going to cause trouble.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.