[gstreamer-bugs] [Bug 607798] x264enc needs updating to support new features

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=607798
  GStreamer | gst-plugins-ugly | git

--- Comment #63 from Robert Swain <robert.swain at gmail.com> 2010-07-11 08:55:33 UTC ---
(In reply to comment #62)
> Properties whose existence depends on a library version are not a good idea. 
> If the library is too old, use a g_warning().

All the properties for this element depend on some x264 API version or another.
Ubuntu Lucid only ships libx264 with API version 85. For the preset/profile
APIs one needs version 86 or newer. 86 was only made available in February. It
was deemed reasonable to do some #if work depending on the version but perhaps
your suggestion is better.

In short, you're suggesting the properties should exist always but if the
library version is less than what we require, we issue a g_warning () from one
of the init function or the set properties function.

> Please break up the patch into parts we are definitely going to change, like
> adding new properties vs. other stuff.  This element should really be fixed
> before the next -ugly release.  Otherwise I'm going to just start applying my
> own, potentially incompatible, changes.

If someone decides there's some part we don't want to change, say so and I'll
split it out. I intend to split out the defaults change. Otherwise as far as
I'm concerned I'm just iterating until it's good enough to land in master (I
still have things on my to do list for this patch so I don't think it is ready
yet) and I will have time to do so before the next -ugly freeze.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.