[gstreamer-bugs] [Bug 594504] Need a GType of "Date AND Time AND Timezone"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=594504
  GStreamer | gstreamer (core) | git

--- Comment #47 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2010-07-18 23:51:39 UTC ---
(In reply to comment #46)
> First the nitpicking:
> 
> > taglist: Add datetime get functions
> 
>  - is missing Since: markers in gtk-doc chunks

Fixed.

> 
> 
> > Adds a datetime functions to gstvalue
> 
>  - -> gstvalue: add datetime functions
> 
>  - has Since: markers with glib version (2.26)

Fixed.

> 
>  - GST_TYPE_DATE_TIME has no Since markers

Fixed.

> 
>  - do we need to expose the _compare() function?
>    I think we should keep it private/internal for now.

Added its prototype to gst_private.h and it is now private.

> 
>  - I assume when GstDateTime is serialised, we now
>   get "(GstDateTime)2010...." right? I wonder if we should
>   add a mnemonic without prefix ("datetime"?) so we
>   don't have problems with "GDateTime" vs. "GstDateTime"
>   later when switching GstDateTime to GDateTime (if it
>   ever happens). Of course we can just leave it at "(GstDateTime)"
>   and add some special casing later.
> 
> 
> > gststructure: Adds datetime getter function
> 
> Why do we need a datetime getter for GstStructure?

Added those to be used on datetime serialization/deserialization tests (in
gstvalue tests).

All other tests uses the GstStructure functions, including GstDate tests.

But I guess I can update the tests to use the GstTagList functions to get them.
Is this preferable?

> 
> 
> > gstvalue: Adds tests for datetime
> 
> Could you fix up the two chunks at the bottom that gst-indent thinks it needs
> to re-indent? Just split them into to GValue foo = { ... }; lines.

Fixed.

> 
> 
> > gstdatetime: Adds GstDateTime
> 
>  - why do we have gst_date_time_get_dmy(), but
>    for the time fields it's _get_hour(), get_minute()
>    etc.? Instead of one function?

Because for days you need to get the month first, and for the month, you'd need
the year. Getting all 3 at once is faster than getting one by one. For the time
functions this doesn't happen.


Have the patches updated locally, will put them here once the still open
discussions above are finished.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.