[gstreamer-bugs] [Bug 624699] Add 'caps' property for playbin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=624699
  GStreamer | gst-plugins-base | unspecified

--- Comment #10 from Zhao, Halley <halley.zhao at intel.com> 2010-07-30 06:54:49 UTC ---
(In reply to comment #5)
> For the second case, video-sink set from app will not take effect. because in
> gstplaybin2.c:
> 1. autoplug_select_cb() will set group->video_sink with sink by auto-plug
> 2. in no_more_pads_cb(), the above sink will take a higher priority than sink
> set from app:
>     if (group->video_sink) {
>       GST_INFO_OBJECT (playbin, "setting custom video sink %" GST_PTR_FORMAT,
>           group->video_sink);
>       gst_play_sink_set_sink (playbin->playsink, GST_PLAY_SINK_TYPE_VIDEO,
>           group->video_sink);
>     } else {
>       GST_INFO_OBJECT (playbin, "setting default video sink %" GST_PTR_FORMAT,
>           playbin->video_sink);
>       gst_play_sink_set_sink (playbin->playsink, GST_PLAY_SINK_TYPE_VIDEO,
>           playbin->video_sink);
>     }
> }
as to the above code.
if we take video_sink set from app as higher priority, it will also be ok for
my case.

if(playbin->video_sink) {
gst_play_sink_set_sink (playbin->playsink, GST_PLAY_SINK_TYPE_VIDEO,
           playbin->video_sink);
} else {
gst_play_sink_set_sink (playbin->playsink, GST_PLAY_SINK_TYPE_VIDEO,
           group->video_sink);
}

is it reasonable?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.