[gstreamer-bugs] [Bug 618853] add caps intersection iterators

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=618853
  GStreamer | gstreamer (core) | unspecified

--- Comment #37 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-06-01 19:30:53 UTC ---
(In reply to comment #29)
> (In reply to comment #26)
> > Created an attachment (id=161869)
 View: https://bugzilla.gnome.org/attachment.cgi?id=161869
 Review: https://bugzilla.gnome.org/review?bug=618853&attachment=161869

[details] [review]
> > avoid using gst_caps_get_size() in gst_pad_fixate_caps
> 
> I think this patch should be applied anyway, it looks much cleaner. The only
> thing I'm wondering is wether we should g_return_if_fail() instead of just
> returning if someone tries to fixate ANY or EMPTY, as both of them cannot be
> fixated.

The gst_caps_is_empty() was obsolete as we had
 g_return_if_fail (!gst_caps_is_empty (caps));
at the begin already. If I also add a
 g_return_if_fail (!gst_caps_is_any (caps));
I get failing tests though:
gstcheck.c:72:F:general:basesrc_eos_events_pull:0: Unexpected critical/warning:
gst_pad_fixate_caps: assertion `!gst_caps_is_any (caps)' failed
gstcheck.c:72:F:general:basesrc_eos_events_pull_live_op:0: Unexpected
critical/warning: gst_pad_fixate_caps: assertion `!gst_caps_is_any (caps)'
failed
gstcheck.c:72:F:general:basesrc_eos_events_pull_live_eos:0: Unexpected
critical/warning: gst_pad_fixate_caps: assertion `!gst_caps_is_any (caps)'
failed

Now I just return quickly for any-caps and add a fixme-0.11. I'll push this in
a sec.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.