[gstreamer-bugs] [Bug 614872] [tag] Add basic exif support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=614872
  GStreamer | gst-plugins-base | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161247|none                        |needs-work
             status|                            |

--- Comment #17 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-06-09 15:58:47 UTC ---
Review of attachment 161247:
 --> (https://bugzilla.gnome.org/review?bug=614872&attachment=161247)

Very nice patch. I only have some formalities - please commit when taken care
of them. (When applying this also need to update the
./win32/common/libgsttag.def.)

::: docs/libs/gst-plugins-base-libs-sections.txt
@@ +1688,3 @@
+gst_tag_list_from_exif_buffer
+<SUBSECTION Standard>
+</SECTION>

should this also contain gst_tag_list_*_with_tiff_header?

::: gst-libs/gst/tag/gstexiftag.c
@@ +27,3 @@
+ *
+ */
+

This needs at least 1 sentence of description.

@@ +144,3 @@
+  {GST_TAG_GEO_LOCATION_LONGITUDE, 0x4, EXIF_TYPE_RATIONAL, 0x3,
+      serialize_geo_coordinate, deserialize_geo_coordinate},
+#if 0

IUs this disabled because we lack the GST_TAG_XX defines? Didn't you files a
bug about it? Maybe add a FIXME: comment and point to the bug.

@@ +391,3 @@
+        break;
+    } else {
+      GST_WARNING ("Unexpected endianness");

maybe check this when setting up the writer/reader. There are already other
places in the code above without the warning.

@@ +546,3 @@
+  /* Add the next IFD offset, we just set it to 0 because
+   * there is no easy way to predict what it is going to be.
+   * The user might rewrite the value if needed */

Maybe this is something that can be explained in the section docs (and then you
can remove the FIXME).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.