[gstreamer-bugs] [Bug 607798] x264enc needs updating to support new features

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=607798
  GStreamer | gst-plugins-ugly | git

--- Comment #37 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2010-06-11 13:36:15 UTC ---
(In reply to comment #28)
> Created an attachment (id=162313)
 View: https://bugzilla.gnome.org/attachment.cgi?id=162313
 Review: https://bugzilla.gnome.org/review?bug=607798&attachment=162313

> Use x264 APIs to better configure libx264 in x264enc
> 
> Hammer it and give feedback please! :)

* _init performs a _build_tunings_string and _default_preset, but that seems
not yet necessary at that stage, as it will be done when needed in
_init_encoder.

* when parsing (user provided option string), g_strsplit need not return 2
strings; is other code sufficiently prepared to handle some NULL safely?

* provided option-string is internally appended to option_string (which is also
appended to by setting "normal properties").  So if option-string is set, and
then again set to e.g. "", the previously set options still remain in effect.
Intended semantics are likely achieved by keeping this option-string in some
separate string (from the one where other options are appended to), and then
only append option-string to the "normal properties" at actual configuration
time.

* why is there a x264enc_defaults (string) variable?  It seems to be used to
set x264param according to the defaults of the properties.  However:

- why mixed ?, i.e. part are set using the x264enc_defaults string, and other
parameter struct members are set directly.
- [nitpick++]  it seems not all properties are currently covered this way.  The
remaining ones may have matching defaults on the properties and in libx264, but
if the latter ones change in some release, then the element may not behave
according to the default setting it claims.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.