[gstreamer-bugs] [Bug 621723] v4l2src crashes on PLAYING->READY->PLAYING

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=621723
  GStreamer | gst-plugins-good | 0.10.25

--- Comment #1 from Havoc Pennington <hp at pobox.com> 2010-06-16 15:25:26 UTC ---
Created an attachment (id=163837)
 View: https://bugzilla.gnome.org/attachment.cgi?id=163837
 Review: https://bugzilla.gnome.org/review?bug=621723&attachment=163837

v4l2src: in negotiate, check for error return from set_caps

Fixes #621723  (partially)

set_caps can fail if the video device is running, in that case
setting its format leads to EBUSY.

If set_caps fails then we will not have set up the buffer pool
(it will be NULL) which leads to a crash when we try to pull
buffers. If we fail the negotiate on set_caps failure, then we
won't go to playing state and won't crash.

This is a small improvement. Of course, a nicer fix would
be to make set_caps work in the case where the format is
unchanged. If the format has changed, failing is
probably correct because we need to close the device
(go to NULL state) in order to set caps.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.