[gstreamer-bugs] [Bug 619508] [tag] Add image orientation tag

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=619508
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #163935|none                        |reviewed
             status|                            |

--- Comment #8 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-06-21 22:43:05 UTC ---
Review of attachment 163935:
 --> (https://bugzilla.gnome.org/review?bug=619508&attachment=163935)

Overall, this seems ok to me. There is a part of me that's not entirely happy
about the covert enum / predefined string values thing, but that part is
equally reluctant to start adding enum tags now, with all the API and bindings
hassle this would entail, especially for a tag like this where there's a clear
noop transform/value. So while it's not the perfect solution, I can't think of
better solutions either, nor imagine a scenario where someone really misses the
possibility to introspect the possible settings here.

::: gst/gsttaglist.c
@@ +353,3 @@
+      _("image orientation"),
+      _("Represents how the image should be rotated or flipped before "
+          "ehxibition"), NULL);

ehxibition => exhibition (or just 'display'?)

::: gst/gsttaglist.h
@@ +945,3 @@
+ *
+ * Represents the 'Orientation' tag from EXIF. Defining how the image
+ * should be rotated and mirrored for ehxibition. (string)

ehxibition => exhibition

@@ +947,3 @@
+ * should be rotated and mirrored for ehxibition. (string)
+ *
+ * This tag has a predefined set of possible inputs:

possible inputs => allowed values maybe ?

@@ +951,3 @@
+ *   "flip-rotate-0"
+ *   "rotate-180"
+ *   "flip-rotate-180"

Can we put these in order now that the original relation to the number value is
gone? ie. 0/90/180/270, etc.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.