[gstreamer-bugs] [Bug 623196] rtpptdemux: don't send custom downstream event twice

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jun 30 03:12:28 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=623196
  GStreamer | gst-plugins-good | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |t.i.m at zen.co.uk
     Ever Confirmed|0                           |1
           Severity|normal                      |blocker

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-06-30 10:12:23 UTC ---
Oh, that would lead to refcounting errors / crashes too I suppose, since
gst_pad_event_default() takes ownership of the event.

However, I'm not sure this makes the code entirely correct yet.

We still leak the event in the else branch of the if (rtpdemuxpad) above. Also,
I wonder if it needs to be gst_pad_get_parent() at the beginning.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list