[gstreamer-bugs] [Bug 623209] New: bug in rtpL16depay

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=623209
  GStreamer | gst-plugins-good | 0.10.23

           Summary: bug in rtpL16depay
    Classification: Desktop
           Product: GStreamer
           Version: 0.10.23
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: nospam12 at hmamail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Hello. I came across this bug while trying to stream raw audio over rtsp (using
rtpL16pay).

Wim Taymans identified the source of the problem to be the depayloader not
using encoding-params for the number of channels.

I confirm that his suggested patch (below) works. Possibly unrelated, the
playback on the raw audio is choppy...the stream is over loopback. Any ideas on
the source of the choppiness?

============

diff --git a/gst/rtp/gstrtpL16depay.c b/gst/rtp/gstrtpL16depay.c
index 619f3ef..590df42 100644
--- a/gst/rtp/gstrtpL16depay.c
+++ b/gst/rtp/gstrtpL16depay.c
@@ -168,9 +168,13 @@ gst_rtp_L16_depay_setcaps (GstBaseRTPDepayload *
depayload, GstCaps * caps)
   if (clock_rate == 0)
     goto no_clockrate;

-  channels = gst_rtp_L16_depay_parse_int (structure, "channels", channels);
-  if (channels == 0)
-    goto no_channels;
+  channels = gst_rtp_L16_depay_parse_int (structure, "encoding-params",
channels);
+  if (channels == 0) {
+    channels = gst_rtp_L16_depay_parse_int (structure, "channels", channels);
+    if (channels == 0) {
+      goto no_channels;
+    }
+  }

   depayload->clock_rate = clock_rate;
   rtpL16depay->rate = clock_rate;

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.