[gstreamer-bugs] [Bug 583890] v4l2: should use pad_alloc

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=583890
  GStreamer | gst-plugins-good | git

Arnout Vandecappelle <arnout> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155125|0                           |1
        is obsolete|                            |

--- Comment #25 from Arnout Vandecappelle <arnout at mind.be> 2010-03-04 17:01:10 UTC ---
Created an attachment (id=155243)
 View: https://bugzilla.gnome.org/attachment.cgi?id=155243
 Review: https://bugzilla.gnome.org/review?bug=583890&attachment=155243

implement pad_alloc_buffer usage

The downstream-allocated buffers were loosing their ref.  Indeed, BaseSrc's
call of create() owns the ref of the returned buffer.  In the old
implementation, the buffers were recovered in the finalize functions, but for
downstream-allocated buffers we have no control over the finalize.  Now they
are recovered in bufferpool_update(), but by that time it's already too late
(buffer has been killed).

So, what I do is I take a ref when a buffer is dequeued.  This way, all the
buffers in the pool always have at least one ref.

Stefan, didn't you have this problem too in your original implementation?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.