[gstreamer-bugs] [Bug 612700] New: pngenc can't be built against libpng 1.4.x anymore

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=612700
  GStreamer | gst-plugins-good | git

           Summary: pngenc can't be built against libpng 1.4.x anymore
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: lrn1986 at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Because libpng 1.4.x declares all png structure members as deprecated in png.h,
and GStreamer recently began to interpret deprecation warnings as errors.

cc1.exe: warnings being treated as errors
gstpngenc.c: In function 'user_write_data':
gstpngenc.c:228: error: 'jmpbuf' is deprecated (declared at
f:/gstreamer-buildslave/msys/1.0.11/local/include/png.h:1061)
gstpngenc.c: In function 'gst_pngenc_chain':
gstpngenc.c:273: error: 'jmpbuf' is deprecated (declared at
f:/gstreamer-buildslave/msys/1.0.11/local/include/png.h:1061)

That is, libpng forbids accessing jmpbuf. Which is necessary to call longjmp()
in user_write_data (png_structp png_ptr, png_bytep data, png_uint_32 length)
handler.
Instead the code should call png_error() which will call longjmp() internally.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.