[gstreamer-bugs] [Bug 611962] tags: Move tags from metadata into -base

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=611962
  GStreamer | gst-plugins-base | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155740|none                        |needs-work
             status|                            |

--- Comment #6 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-03-13 07:01:40 UTC ---
Review of attachment 155740:
 --> (https://bugzilla.gnome.org/review?bug=611962&attachment=155740)

Thanks for cleaning this up. A few more small comments below:

::: gst-libs/gst/tag/gstimagetags.c
@@ +49,3 @@
+ *
+ * This module register tags need for image metadata.
+ *

typo: register_s_

@@ +68,3 @@
+ * extern functions implementations
+ */
+

remove above comment. no externs here

@@ +229,3 @@
+   * Other  = reserved
+   */
+  /* FIXME: this seems complex */

Can a GFlag be used here (like a GEnum below)?

::: gst-libs/gst/tag/gstimagetags.h
@@ +64,3 @@
+ * The whole data in an EXIF tag, as stored in a file
+ */
+#define GST_TAG_EXIF                       "exif"

These doc-comments (this and below) are a bit weird. Could you please make them
e.g.:
/*
 * GST_TAG_EXIF:
 *
 * The whole data of an EXIF section as a #GstBuffer.
 */

::: gst-libs/gst/tag/gstimagetagsdefs.h
@@ +158,3 @@
+  GST_TAG_CAPTURE_WHITE_BALANCE_FLASH,
+  GST_TAG_CAPTURE_WHITE_BALANCE_HORIZON  /* sun on the horizon */
+} GstTagCaptureWhiteBalance;

move comment to doc blob

@@ +184,3 @@
+ * @GST_TAG_CAPTURE_LIGHT_SOURCE_OTHER_LIGHT_SOURCE:
+ */
+/* Some notes that might help in the doc

could you move those to the above doc comment?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.