[gstreamer-bugs] [Bug 520697] [API] Add GST_TAG_USER_RATING

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Mar 23 10:37:59 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=520697
  GStreamer | gstreamer (core) | git

--- Comment #8 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-03-23 17:37:57 UTC ---
Review of attachment 156883:
 --> (https://bugzilla.gnome.org/review?bug=520697&attachment=156883)

Looks good to me.

::: gst/gsttaglist.c
@@ +326,3 @@
+  gst_tag_register (GST_TAG_USER_RATING, GST_TAG_FLAG_META, G_TYPE_UINT,
+      _("user rating"),
+      _("Rating attributed to a content by a user. The higher the rank, "

I'd drop the 'to a content' bit.

::: gst/gsttaglist.h
@@ +883,3 @@
+ * GST_TAG_USER_RATING
+ *
+ * Rating attributed to a content by a person (likely the application user).

Again, maybe drop the 'to a content'.

@@ +884,3 @@
+ *
+ * Rating attributed to a content by a person (likely the application user).
+ * The higher the rank the value, the more the user likes this media

Drop 'the rank'.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list