[gstreamer-bugs] [Bug 612540] Build releases (X.Y.0) with -DG_DISABLE_CAST_CHECKS

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Mar 24 13:52:12 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=612540
  GStreamer | common | git

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-03-24 20:52:07 UTC ---
Olivier: I agree, but I don't think the proposed change would have a noticable
impact on debuggability in practice. Keep in mind that this only affects casts
within GStreamer core/libs and within GStreamer plugins, not external plugins
such as farsight or applications.

Where you would have gotten a warning and a crash, you now only get a crash
without the cast warning. This is not the kind of thing that's hard to debug.
Besides, these kind of failures hardly ever happen at all. Can you remember the
last time you ran into this kind of thing (triggered by GStreamer code)? I
can't.

And I do think we have lots of guards in all important places. If there are
guards missing somewhere, we should add some.

The only thing I'm unsure about is whether this flag should be enabled/disabled
based on whether git is used or not. I think we should probably either always
use it or never use it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list