[gstreamer-bugs] [Bug 610249] [xoverlay] add set_render_rectangle() methods

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=610249
  GStreamer | gst-plugins-base | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #22 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-03-28 20:22:39 UTC ---
> Regarding unsetting, lets keep it -1/-1/-1/-1 then. Dunno if we might want to
> use 0/0/0/0 to "hide" the overlay in the future.

Originally I thought one might want to have the possibility to use width/height
= -1 for 'as much as available' (in which case 0/0/-1/-1 would be the natural
way to reset), but I guess that doesn't really make sense for the use case of
this API, since the caller knows the width/height of the display. Anyway, let's
leave it at all -1/invalid to reset for now.

commit 37d000d175dad226f5eacbefe557f107cb43e6a6
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed Mar 24 09:59:42 2010 +0000

    xoverlay: change new set_render_rectangle() vfunc to take four arguments so
we don't depend on libgstvideo

    Don't make libgstinterfaces (and thus libgstaudio etc.) indirectly depend
    on libgstvideo by using the GstVideoRectangle helper structure in the API,
    which causes undesirable dependencies, esp. with the gobject-introspection
    (people will point and laugh at us if they find out that libgstaudio
    depends on libgstvideo). Instead, pass the x, y, width and height
parameters
    directly to the function.

    Re-fixes #610249.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.