[gstreamer-bugs] [Bug 617339] pulsesink doesn't make use of pa_stream_begin_write

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=617339
  GStreamer | gst-plugins-good | git

--- Comment #1 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-05-05 12:53:26 UTC ---
Review of attachment 160029:
 --> (https://bugzilla.gnome.org/review?bug=617339&attachment=160029)

The patch looks quite good to me. I wonder if thinks could be refactored
somewhat to reduce the copy and paste between the the two branches of the
#ifdef HAVE_PULSE_0_9_16 in gst_pulseringbuffer_commit(). Maybe some static
inline functions. Should a similar change also be made for the source?

::: ext/pulse/pulsesink.c
@@ +1257,3 @@
+    GST_LOG_OBJECT (psink,
+        "need to write %d samples at offset %" G_GINT64_FORMAT, *toprocess,
+        offset);

the log statement could stay out of the ifdef (its the same in #else)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.