[gstreamer-bugs] [Bug 617314] pbutils: Add codec-specific utility functions
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri May 7 03:31:56 PDT 2010
https://bugzilla.gnome.org/show_bug.cgi?id=617314
GStreamer | gst-plugins-base | unspecified
--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-05-07 10:31:52 UTC ---
Ok, so some thoughts:
- I like having these utility functions in a central place, and
pbutils seems as good a place as any
- I think we should drop the pb_utils from the API, so e.g.
gst_codec_utils_aac_*(),
gst_codec_utils_h264_*()
etc. (it's not very consistent within pbutils, but I think this
is nicer).
- there's still a bit of a mishmash between parsing bits
caller side and not, e.g. _aac_get_sample_rate() makes
the caller parse the header/codec data to extract the
sample rate index, while other functions do not. I think
it would be nicer API-wise if the caller didn't have to do
that. If needed, one would have to have an _get_sample_rate()
and e.g. a _get_sample_rate_from_adts_header() or
somesuch.
- while the _get_foo() API is fairly clean and in line with
what we do elsewhere, I wonder if it wouldn't be better
to have functions that operate on, or return, caps
straight away, instead of doing the whole
foo = get_foo(); if (foo); gst_caps_set_simple (...);
dance caller side. Then you'd just have e.g.
gst_codec_utils_aac_get_caps()
etc.
Thoughts?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the Gstreamer-bugs
mailing list