[gstreamer-bugs] [Bug 618305] New: [flvmux] last timestamp is stored even if it's invalid

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=618305
  GStreamer | gst-plugins-good | git

           Summary: [flvmux] last timestamp is stored even if it's invalid
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: wulczer at wulczer.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


For example:

$ gst-launch audiotestsrc num-buffers=10 ! speexenc ! flvmux ! filesink
location=/tmp/foo.flv

$ debug-flv /tmp/foo.flv
(...)
#00002 <AudioTag at offset 0x000009F1, time 0, size 81, Speex>
#00003 <AudioTag at offset 0x00000A51, time 2007021037, size 71, Speex>
#00004 <AudioTag at offset 0x00000AA7, time 2007021037, size 75, Speex>
(...)

the third and fourth FLV tag have a ridiculous timestamp. That's because flvmux
saves the timestamp of the last buffer pushed and uses it if the incoming
buffer has an invalid timestamp and it does it regardless of whether that
timestamp to be saved is valid or not.

The solution is to only store the last timestamp if it's valid.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.