[gstreamer-bugs] [Bug 618853] add caps intersection iterators

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=618853
  GStreamer | gstreamer (core) | unspecified

--- Comment #14 from Sebastian Dröge <slomo at circular-chaos.org> 2010-05-18 12:58:30 UTC ---
Review of attachment 161350:
 --> (https://bugzilla.gnome.org/review?bug=618853&attachment=161350)

::: gst/gstcaps.c
@@ +1539,3 @@
+  /* return special case signleton iterators */
+  if (G_UNLIKELY (CAPS_IS_EMPTY (caps))) {
+    if (!__gst_empty_caps_iterator) {

You should use g_once_init_* here or initialize somewhere from gst_init() for
thread safety

@@ +1705,3 @@
+        goto restart;
+        break;
+      default:

You should handle RESYNC here by resyncing the child iterators and starting
again from the beginning.

Use case for this would be a custom caps iterator on a pad, which resyncs
whenever properties or something change.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.