[gstreamer-bugs] [Bug 618982] New: wrong segment times in wavparse?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=618982
  GStreamer | gst-plugins-good | 0.10.22

           Summary: wrong segment times in wavparse?
    Classification: Desktop
           Product: GStreamer
           Version: 0.10.22
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: petrem at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=161354)
 View: https://bugzilla.gnome.org/attachment.cgi?id=161354
 Review: https://bugzilla.gnome.org/review?bug=618982&attachment=161354

suggested patch

While doing non-flushing seeks on a wavparse element, got gstreamer complaining
that assertion 'start <= stop' is false.

Using gstreamer0.10.29, gst-plugins-base0.10.29, gst-plugins-good0.10.22

I am not sure what's going on in gstreamer, so this might be just my fault, but
in gstwavparse.c, at line 970 (in gst_wavparse_perform_seek()), we have:

wav->close_segment = gst_event_new_new_segment (TRUE,
      wav->segment.rate, wav->segment.format,
      wav->segment.accum, wav->segment.last_stop, wav->segment.accum);

I think that the 4th parameter should be wav->segment.start. Changing this
makes the error disapear. I've attached a tentative patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.