[gstreamer-bugs] [Bug 619290] [vp8] add mode property to switch between CBR/VBR

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=619290
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161641|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2010-05-21 14:09:23 UTC ---
Review of attachment 161641:
 --> (https://bugzilla.gnome.org/review?bug=619290&attachment=161641)

::: ext/vp8/gstvp8enc.c
@@ +679,3 @@
       cfg.rc_min_quantizer = 63 - encoder->quality * 5.0;
       cfg.rc_max_quantizer = 63 - encoder->quality * 5.0;
       cfg.rc_target_bitrate = encoder->bitrate;

In so we have VBR with the quality property & mode==vbr, ABR with bitrate &
mode==vbr and CBR with bitrate & mode==cbr?

Is it maybe useful to allow values between VPX_VBR and VPX_CBR and set
quantizers when using a target bitrate?

Other than that I think something like this is a good idea.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.