[gstreamer-bugs] [Bug 619300] [qtdemux] mpeg audio version 2 is reported as version 1

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=619300
  GStreamer | gst-plugins-good | git

--- Comment #5 from Josep Torra Valles <n770galaxy at gmail.com> 2010-05-21 16:13:41 UTC ---
As had been talked on IRC the patch isn't suficient, in terms of gstreamer caps
we are currently using:

mpegversion = 1 layer {1,2,3} for all variants of MP3

and

mpegversion = {2, 4} for AAC

In ISO/IEC 13818-7:

8.1.4   Audio Data Transport Stream ADTS
The Audio Data Transport Stream (ADTS) is similar to syntax used in ISO/IEC
11172-3 and
ISO/IEC 13818-3. This will be recognized by ISO/IEC 11172-3 decoders as a
“Layer 4”
bitstream.
The fixed header of the ADTS contains the syncword plus all parts of the header
which are
necessary for decoding and which do not change from frame to frame. The
variable header
of the ADTS contains header data which changes from frame to frame.

Maybe we should have caps for the following:

MP3: mpegversion = 1 layer = {1,2,3} and mpegversion = 2 layer = 3
AAC: mpegversion = 2 layer = 4 and mpegversion = 4

The main reason is correctness on typefinding.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.