[gstreamer-bugs] [Bug 619045] [PATCH] Spectrum doesn't support 24-bit depth
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon May 24 01:27:27 PDT 2010
https://bugzilla.gnome.org/show_bug.cgi?id=619045
GStreamer | gst-plugins-good | git
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #161821|none |needs-work
status| |
--- Comment #11 from Sebastian Dröge <slomo at circular-chaos.org> 2010-05-24 08:27:21 UTC ---
Review of attachment 161821:
--> (https://bugzilla.gnome.org/review?bug=619045&attachment=161821)
::: gst/spectrum/gstspectrum.c
@@ +576,3 @@
+ }
+ if (value & 0x800000)
+ value = -(value ^ 0xffffff) - 1;
Use something like this here, that's used in GstByteReader too for example.
Your's works too of course but that's a bit larger ;)
#if G_BYTE_ORDER == G_BIG_ENDIAN
value = GST_UTIL_READ_UINT24_BE (data);
#else
value = GST_UTIL_READ_UINT24_LE (data);
#endif
if (value & 0x00800000)
val |= 0xff000000;
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the Gstreamer-bugs
mailing list