[gstreamer-bugs] [Bug 619502] [mpegvideoparse] segfault because of access to a NULL buffer gotten from mpeg_packetizer_get_block

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=619502
  GStreamer | gst-plugins-bad | git

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-05-24 20:05:20 UTC ---
Something still doesn't feel entirely right to me here. I would expect the
parse/packetizer logic to work exactly the same, whether downstream is linked
or not.

I'm also not entirely convinced the additional if (buf != NULL) check, which is
obviously needed with the current semantics of the _get_block() function, is in
the right place here. If we put it into the while() loop, then the packetizer
will never advance to the next block from the looks of it.

Maybe it should instead be:


-    if (cur->flags & MPEG_BLOCK_FLAG_SEQUENCE) {
+   if ((cur->flags & MPEG_BLOCK_FLAG_SEQUENCE) && buf != NULL) {

just below the while()?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.