[gstreamer-bugs] [Bug 619533] [avimux, matroskamux, flvmux] crash when receiving tags on multiple pads at the same time

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=619533
  GStreamer | gst-plugins-good | git

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-05-25 16:37:11 UTC ---
> Even with the GstTagSetter fixes there's a race though:
> 
>       GST_OBJECT_LOCK (avimux);
>       mode = gst_tag_setter_get_tag_merge_mode (setter);
>       gst_tag_setter_merge_tags (setter, list, mode);
>       GST_OBJECT_UNLOCK (avimux);
> 
> The mode could change between the two gst_tag_setter calls.

Well sure, but no one should be changing the mode in state >READY anyway. It
seems a rather unlikely corner case, and I'd be more worried then about two
threads simultaneously creating the TagData chunk and one thread indirectly
invalidating the one the other continues to use. Also, it doesn't really matter
if the mode changes just after we read it. It's just potluck which value gets
chosen by the streaming thread in this case, there's no defined behaviour.
(This is assuming we read the value correctly, which would not necessarily be
the case strictly speaking, but again: purely hypothetical unlikely corner case
IMHO).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.