[gstreamer-bugs] [Bug 633918] [fakesink] [PATCH] print sink-message events like a message and its structure

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=633918
  GStreamer | gstreamer (core) | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173786|none                        |needs-work
             status|                            |

--- Comment #1 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-11-08 13:19:13 UTC ---
Review of attachment 173786:
 --> (https://bugzilla.gnome.org/review?bug=633918&attachment=173786)

Good idea. I can push after the small detail got fixed and git is open for
commits.

::: plugins/elements/gstfakesink.c
@@ +414,2 @@
+    if (!g_strcmp0 ("sink-message", str_name)) {
+      GstMessage *msg;

wouldn't it be better to do GST_EVENT_TYPE(event)==GST_EVENT_SINK_MESSAGE?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.