[gstreamer-bugs] [Bug 634431] xvimagesink event handling is bad

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=634431
  GStreamer | gst-plugins-base | unspecified

--- Comment #1 from Levente Farkas <lfarkas at lfarkas.org> 2010-11-10 12:46:14 UTC ---
I try to create a patch for xvimagesink but I've never do any kind of X
programming, so I got a few questions about the current implementation in
xvimagesink.c:

why not add VisibilityChangeMask in anywhere to the XSelectInput's mask? imho
it'd be useful eg. if a tooltip or popup menu partially overlaying the window
than it'd be useful to expose even in this case.

in line 2869 and 2912 what if not xvimagesink->xwindow->internal (or xwindow_id
is 0 which is the same) why not add ButtonPressMask | ButtonReleaseMask? is
there any reason for this?

is there any reason not to handle EnterWindowMask and LeaveWindowMask? they are
properly handled on windows direct video sinks.

thanks in advance.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.