[gstreamer-bugs] [Bug 635229] New: Uninitialized variable in celt encoder can cause segfault

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=635229
  GStreamer | gst-plugins-bad | 0.10.20

           Summary: Uninitialized variable in celt encoder can cause
                    segfault
    Classification: Desktop
           Product: GStreamer
           Version: 0.10.20
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: wheeler at willowgarage.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


In gstceltenc.c, a variable, 'empty_tags', is uninitialized in the
gst_celt_enc_create_metadata_buffer() function.  If the value is non-NULL, then
it is passed to gst_tag_list_free().  This can cause random segmentation
violation depending on what is on your stack at the time.  Here is a simple
patch:

--- ext/celt/gstceltenc.c    2010-11-18 15:30:05.391711020 -0800
+++ ext/celt.new/gstceltenc.c    2010-11-18 15:29:40.222616006 -0800
@@ -591,7 +591,7 @@
 gst_celt_enc_create_metadata_buffer (GstCeltEnc * enc)
 {
   const GstTagList *tags;
-  GstTagList *empty_tags;
+  GstTagList *empty_tags = NULL;
   GstBuffer *comments = NULL;

   tags = gst_tag_setter_get_tag_list (GST_TAG_SETTER (enc));

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.