[gstreamer-bugs] [Bug 627211] jpegformat: Push tags after setting srcpad caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627211
  GStreamer | gst-plugins-bad | unspecified

Thiago Sousa Santos <thiago.sousa.santos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168562|none                        |needs-work
             status|                            |

--- Comment #5 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2010-11-19 01:15:27 UTC ---
Review of attachment 168562:
 --> (https://bugzilla.gnome.org/review?bug=627211&attachment=168562)

It seems that none of the functions were using take ownership of the taglist,
so we might be leaking it here and there.

FYI, this seems to be present even without the patch.

::: gst/jpegformat/gstjpegparse.c
@@ +581,3 @@
+              parse->priv->tags = gst_tag_list_new ();
+            gst_tag_list_insert (parse->priv->tags, tags,
+                GST_TAG_MERGE_REPLACE);

Leaks the tags

@@ +607,3 @@
+              parse->priv->tags = gst_tag_list_new ();
+            gst_tag_list_insert (parse->priv->tags, tags,
+                GST_TAG_MERGE_REPLACE);

Leaks the tags

@@ +791,3 @@
+      gst_element_found_tags_for_pad (GST_ELEMENT_CAST (parse),
+          parse->priv->srcpad, parse->priv->tags);
+      parse->priv->tags = NULL;

found_tags_for_pad makes a copy from the taglist, so we need to free it here,
too.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.